feat: Add feature to store custom_files and config in a subdir for each experiment #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Question; does things like |
Yes, they work fine, although the increment-training will just update the current run.env inside the same experiment folder. I plan to add another command to increment the whole experiment folder which will also update the DR_EXPERIMENT_NAME and increment model prefix + set pretrained prefix. |
larsll
requested changes
Dec 11, 2024
| @@ -27,5 +27,6 @@ DR_WEBVIEWER_PORT=8100 | |||
| # DR_REMOTE_MINIO_URL=http://mynas:9000 | |||
| # DR_ROBOMAKER_CUDA_DEVICES=0 | |||
| # DR_SAGEMAKER_CUDA_DEVICES=0 | |||
| # DR_EXPERIMENT_NAME= | |||
There was a problem hiding this comment.
Would this not better be a run.env variable?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The feature enables each training session to have it's config and custom_files stored within a subdir under
experiments/.This simplifies being able to locate the config and files that were used for a particular training session.
An additional flag is added to system.env to control the experiment name, which when set will cause the rest of the config to be loaded from
$DR_DIR/experiments/<experiment_name>/run.envand$DR_DIR/experiments/<experiment_name>/custom_files/.